From d838836acaecadc0ba544c966587177184ed5490 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Fri, 5 Sep 2025 16:18:07 -0400 Subject: [PATCH] update --- ...ent_11_3fd6288ceff0ef378559a9a784510004._comment | 5 +++-- ...ment_8_853bf59715ac755d046b54b282eaac7c._comment | 13 ++++++++++--- 2 files changed, 13 insertions(+), 5 deletions(-) diff --git a/doc/bugs/35_failed_tests_on_beegfs/comment_11_3fd6288ceff0ef378559a9a784510004._comment b/doc/bugs/35_failed_tests_on_beegfs/comment_11_3fd6288ceff0ef378559a9a784510004._comment index c343275796..fb92f27cea 100644 --- a/doc/bugs/35_failed_tests_on_beegfs/comment_11_3fd6288ceff0ef378559a9a784510004._comment +++ b/doc/bugs/35_failed_tests_on_beegfs/comment_11_3fd6288ceff0ef378559a9a784510004._comment @@ -6,6 +6,7 @@ I've now converted *all* functions listed above to ones that set the close-on-exec flag. (When building with the OsPath flag.) -All that remains is the openTempFile race and checking the libraries in -comment #8. +And checked all the libraries in comment #8. + +All that remains is the openTempFile race. """]] diff --git a/doc/bugs/35_failed_tests_on_beegfs/comment_8_853bf59715ac755d046b54b282eaac7c._comment b/doc/bugs/35_failed_tests_on_beegfs/comment_8_853bf59715ac755d046b54b282eaac7c._comment index 997300e64e..8e2bcc5d3a 100644 --- a/doc/bugs/35_failed_tests_on_beegfs/comment_8_853bf59715ac755d046b54b282eaac7c._comment +++ b/doc/bugs/35_failed_tests_on_beegfs/comment_8_853bf59715ac755d046b54b282eaac7c._comment @@ -20,9 +20,16 @@ with a file in the git-annex repo. Most dependencies of git-annex clearly don't open files there, and most open no files at all. Ones I need to check: -* persistent-sqlite -* feed (parseFeedFromFile uses openBinaryFile, updated git-annex to open +* persistent-sqlite (looks ok; no direct uses of problem haskell + functions. And in sqlite itself, `robust_open` sets the close-on-exec + flag) +* feed (update: parseFeedFromFile uses openBinaryFile, updated git-annex to open the file itself instead) -* concurrent-output (addOutputBuffer uses openTempFile; emitOutputBuffer uses T.readFile) +* concurrent-output (addOutputBuffer uses openTempFile; emitOutputBuffer + uses T.readFile. Probably neither actually triggers as git-annex uses the + library though. I have noted it in the todo for that library though.) * magic (update: checked it, it sets close-on-exec) + +At this point, I'm reasonably satisfied about libraries not causing +the problem. """]] -- 2.30.2